dao-jun commented on code in PR #22221:
URL: https://github.com/apache/pulsar/pull/22221#discussion_r1524433763
##########
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/OpAddEntry.java:
##########
@@ -200,7 +210,7 @@ public void addComplete(int rc, final LedgerHandle lh, long
entryId, Object ctx)
lh == null ? -1 : lh.getId(), entryId, dataLength, rc);
}
- if (rc != BKException.Code.OK) {
+ if (rc != BKException.Code.OK || timeoutTriggered.isTrue()) {
Review Comment:
My fault, only executed addops canbe added to pendingAddOps.
But it looks like it will lead to continuous Switching of Ledgers.
Say, there are 1,2,3 AddOp to ledger 1.
If 1 is timeout, the value of `currentLedgerTimeoutTriggered` will set to be
true, and switch to a new ledger.
After 2 is finished, the value of `currentLedgerTimeoutTriggered` is true,
it will also switch to a new ledger.
Same as 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
