poorbarcode commented on code in PR #22221:
URL: https://github.com/apache/pulsar/pull/22221#discussion_r1531505030
##########
pulsar-common/src/main/java/org/apache/pulsar/common/mutable/AtomicMutableBoolean.java:
##########
@@ -0,0 +1,165 @@
+package org.apache.pulsar.common.mutable;
+
+import org.apache.commons.lang3.BooleanUtils;
+import org.apache.commons.lang3.mutable.MutableBoolean;
+
+public class AtomicMutableBoolean extends MutableBoolean {
Review Comment:
> can we just pass null to OpAddEntry when setAddEntryTimeoutSeconds is
disabled?
Since the type of it is a wrap object, set to `null` is confusing. For
example there is a variable typed `Optional<Object>,` and it has been set to
`null` 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
