Demogorgon314 commented on code in PR #22753:
URL: https://github.com/apache/pulsar/pull/22753#discussion_r1609170585
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -1122,6 +1126,35 @@ public void writeBrokerDataOnZooKeeper(boolean force) {
}
}
+ /**
+ * sort bundles by load and select topK bundles for each broker.
+ * @return the number of bundles selected
+ */
+ private CompletableFuture<Integer> selectTopKBundle() {
+ CompletableFuture<Integer> completableFuture = new
CompletableFuture<>();
+
+ executors.execute(() -> {
+ // make the bundle-data update and sorting executed in single
thread
Review Comment:
Why do we run it on a single thread? Can we use `synchronized` here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
