heesung-sn commented on code in PR #22753:
URL: https://github.com/apache/pulsar/pull/22753#discussion_r1610794576
##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -1122,6 +1126,32 @@ public void writeBrokerDataOnZooKeeper(boolean force) {
}
}
+ /**
+ * sort bundles by load and select topK bundles for each broker.
+ * @return the number of bundles selected
+ */
+ private int selectTopKBundle() {
+ bundleArr.clear();
+ bundleArr.addAll(loadData.getBundleData().entrySet());
+
+ int maxNumberOfBundlesInBundleLoadReport = pulsar.getConfiguration()
Review Comment:
Currently, loadBalancerMaxNumberOfBundlesInBundleLoadReport is 10 by
default. I wonder if this behavior change is accdptable. Shouldn't we get the
Pulsar community's agreement to change this behavior? I still think it is safe
to introduce a new flag to control this topk behavior for the modular load
manager and by default it might need to be disabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
