heesung-sn commented on code in PR #22753:
URL: https://github.com/apache/pulsar/pull/22753#discussion_r1610883878


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/loadbalance/impl/ModularLoadManagerImpl.java:
##########
@@ -1122,6 +1126,32 @@ public void writeBrokerDataOnZooKeeper(boolean force) {
         }
     }
 
+    /**
+     * sort bundles by load and select topK bundles for each broker.
+     * @return the number of bundles selected
+     */
+    private int selectTopKBundle() {
+        bundleArr.clear();
+        bundleArr.addAll(loadData.getBundleData().entrySet());
+
+        int maxNumberOfBundlesInBundleLoadReport = pulsar.getConfiguration()

Review Comment:
   I am worried about any possible regression caused by this behavior change. 
It would be great if we could double-confirm with the community. 
   
   For example, this might cause a large cluster to take more time to balance 
load.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to