lhotari commented on PR #24100: URL: https://github.com/apache/pulsar/pull/24100#issuecomment-2740250910
> In this case, regardless of this fix. the user wont get the consumer object, which is expected. > > Because the subscribe throw an exception, that's not the focus. The focus is that we need to close this consumer. @shibd I point was that once there's a bug, a good practice would be to add a failing test case which reproduces the issue and clarifies it. In this case "the user wont get the consumer object, which is expected" could be understood in many ways. It might be clear to yourself, but not for code reviewers. That's why "failing test cases" reproducing the exact problem are always desired when it's possible to add one. Obviously for many Pulsar bugs that's really hard. In this case, it most likely isn't hard. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
