lhotari commented on PR #24100: URL: https://github.com/apache/pulsar/pull/24100#issuecomment-2742559297
> hi, @lhotari , I respect all your opinions, but I really didn't understand what you meant. > > Could you comment directly on the code about what needs to be changed? Or could you show the test you want directly in the code? Thanks @shibd. It is simply about "Cannot close the consumer since user will get InterruptedException and in this case user can't get consumer object". I don't understand the part "and in this case user can't get consumer object" and was expecting that a test case would have clarified it. Now, reading your comments again, it seems that "user can't get consumer object" is expected behavior and this sentence is just misleading and that's not something to be tested in the first place as you have described. Rephrasing the sentence in the description would be a way to resolve this in that case. This isn't a blocker. I'll check what a LLM would suggest for the PR description using the solution described in https://gist.github.com/lhotari/81f533af4b9ad515e02d96e543c4408b. It usually gives a pretty good draft and an LLM can be used to also fix grammar issues in the PR description. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
