shibd commented on PR #24100: URL: https://github.com/apache/pulsar/pull/24100#issuecomment-2740316682
I don't want to waste your time. I believe I've already added tests to cover it. You'll see that I've covered in the tests that the consumer will be removed(closed) after this PR fix. That's the issue I'm addressing. In this scenario, not getting the consumer object is expected. Why would we add a test case for it? A method throws an exception, and you want to cover that it returns null? If you can review the code directly and let me know where improvements are needed, I'd be happy to optimize it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
