lhotari commented on PR #25289: URL: https://github.com/apache/pulsar/pull/25289#issuecomment-4021665970
> > In some cases, the calling code might be currently relying on exceptions being thrown before the actual asynchronous job is created. > > Thanks for raising this, I reviewed the call sites of the methods changed in this PR to check your concern specifically， in the current in-repo callers, I didn’t find that pattern. Most call sites are already handling failures via thenCompose / exceptionally or by awaiting the returned future (get/join), so the error is still observed through the async path. > > Could you give me some cases? Thanks for checking that. IIRC, I've seen the pattern where the error handling relies on a pattern where the async job wouldn't be created at all at least for some method calls that return a CompletableFuture. However, it's possible that those methods have been eliminated over the years and the error handling has been modified to take this change in the method contract into account. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
