lhotari commented on PR #25289: URL: https://github.com/apache/pulsar/pull/25289#issuecomment-4022207858
> Additionally, I can’t guarantee that all problematic methods have been updated in this PR. I’ve done my best to address as many as possible. No worries. Unless CI doesn't catch the issues, we cannot do much more about it. > Would it be possible to add the main purpose of this PR to the AI review rules, and prevent new errors from being introduced? Do you mean the tuning of Copilot review guidance? I haven't checked how that is handled. For Pulsar "plugin interface" changes, there should be an automated solution in place in the CI pipeline that prevents accidential changes that break binary compatibility of interfaces. There's https://github.com/siom79/japicmp for checking all public API changes, but I don't know if it's possible to limit it to check only specific interfaces, for example the interfaces annotated with `org.apache.pulsar.common.classification.InterfaceStability.Stable`. It would be useful to add an AGENTS.md by explaining this since I'd assume that AI tools would at least be able to check changes at some level. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
