zhanghaou commented on PR #25289: URL: https://github.com/apache/pulsar/pull/25289#issuecomment-4022084305
> I think it's necessary to remove LedgerOffloader and LoadManager interface changes from this PR since the changes would break third party implementations. It's better to handle the interface changes for these "plugin interfaces" separately since according to our guidelines, we'd create a PIP for such changes. The other changes LGTM after checking them. Make sense. Additionally, I can’t guarantee that all problematic methods have been updated in this PR. I’ve done my best to address as many as possible. Would it be possible to add the main purpose of this PR to the AI review rules, and prevent new errors from being introduced? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
