[GitHub] [pulsar] Renkai commented on a change in pull request #9202: PIP 76: Streaming Offload(Part II)

[GitBox]

Renkai commented on a change in pull request #9202:
URL: https://github.com/apache/pulsar/pull/9202#discussion_r569158837



##########
File path: 
managed-ledger/src/main/java/org/apache/bookkeeper/mledger/LedgerOffloader.java
##########
@@ -163,7 +166,7 @@ public OffloadResult(long beginLedger, long beginEntry, 
long endLedger, long end
     default CompletableFuture<OffloadHandle> streamingOffload(ManagedLedger 
ml, UUID uid, long beginLedger,
                                                               long beginEntry,
                                                               Map<String, 
String> driverMetadata) {
-        throw new UnsupportedOperationException();
+        throw new UnsupportedOperationException(this.getClass().toString() + " 
streamingOffload");

Review comment:
       As features of offloader go rich, there will be many offloaders 
partially implement offloader(like mock offloaders in test), so have a default 
implementation can reduce boilerplate code.
   <img width="818" alt="image" 
src="https://user-images.githubusercontent.com/3381789/106706704-0812aa80-662b-11eb-8fca-614a3e88227c.png";>
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org