Renkai commented on a change in pull request #9202: URL: https://github.com/apache/pulsar/pull/9202#discussion_r570009007
########## File path: tiered-storage/jcloud/src/test/java/org/apache/bookkeeper/mledger/offload/jcloud/StreamingOffloadTest.java ########## @@ -0,0 +1,217 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.bookkeeper.mledger.offload.jcloud; + +import static org.apache.bookkeeper.mledger.offload.OffloadUtils.isStreamingOffloadCompleted; +import static org.testng.Assert.assertEquals; +import java.io.IOException; +import java.time.Duration; +import java.util.HashMap; +import java.util.concurrent.ExecutionException; +import java.util.concurrent.TimeUnit; +import lombok.extern.slf4j.Slf4j; +import org.apache.bookkeeper.mledger.Entry; +import org.apache.bookkeeper.mledger.LedgerOffloader; +import org.apache.bookkeeper.mledger.ManagedCursor; +import org.apache.bookkeeper.mledger.ManagedLedgerConfig; +import org.apache.bookkeeper.mledger.ManagedLedgerException; +import org.apache.bookkeeper.mledger.impl.ManagedLedgerImpl; +import org.apache.bookkeeper.mledger.impl.PositionImpl; +import org.apache.bookkeeper.mledger.offload.jcloud.impl.BlobStoreManagedLedgerOffloaderStreamingTest; +import org.apache.bookkeeper.mledger.offload.jcloud.provider.TieredStorageConfiguration; +import org.apache.bookkeeper.test.MockedBookKeeperTestCase; +import org.apache.pulsar.common.policies.data.OffloadPolicies; +import org.awaitility.Awaitility; +import org.testng.Assert; +import org.testng.annotations.Test; + +@Slf4j +public class StreamingOffloadTest extends MockedBookKeeperTestCase { + + BlobStoreManagedLedgerOffloaderStreamingTest offloaderGenerator = new BlobStoreManagedLedgerOffloaderStreamingTest(); + + public StreamingOffloadTest() throws Exception { + } + + @Test + public void testStreamingOffload() throws ManagedLedgerException, InterruptedException, IOException, + ExecutionException { + LedgerOffloader offloader = offloaderGenerator.getOffloader( + new HashMap<String, String>() {{ + put(TieredStorageConfiguration.MAX_OFFLOAD_SEGMENT_SIZE_IN_BYTES, "1000"); + put(offloaderGenerator.getConfig().getKeys(TieredStorageConfiguration.METADATA_FIELD_MAX_BLOCK_SIZE) + .get(0), "5242880"); + put(TieredStorageConfiguration.MAX_OFFLOAD_SEGMENT_ROLLOVER_TIME_SEC, "600"); + put("offloadMethod", OffloadPolicies.OffloadMethod.STREAMING_BASED.getStrValue()); + }} + ); + log.info("offloader.getClass() = {}", offloader.getClass()); + int ENTRIES_PER_LEDGER = 10; + ManagedLedgerConfig config = new ManagedLedgerConfig(); + config.setMaxEntriesPerLedger(ENTRIES_PER_LEDGER); + config.setMinimumRolloverTime(0, TimeUnit.SECONDS); + config.setRetentionTime(10, TimeUnit.MINUTES); + config.setRetentionSizeInMB(10); + config.setLedgerOffloader(offloader); + + ManagedLedgerImpl ledger = (ManagedLedgerImpl) factory.open("my_test_ledger", config); + + for (int i = 0; i < ENTRIES_PER_LEDGER * 2.5; i++) { + String content = "entry-" + i; + ledger.addEntry(content.getBytes()); + } + final LedgerOffloader.OffloadHandle currentOffloadHandle = ledger.getCurrentOffloadHandle(); + currentOffloadHandle.close(); + final LedgerOffloader.OffloadResult offloadResult = currentOffloadHandle.getOffloadResultAsync().get(); + log.info("offloadResult = " + offloadResult); + log.info("offload method: " + ledger.getOffloadMethod()); + } + + @Test + public void testStreamingOffloadAndRead() throws ManagedLedgerException, InterruptedException, IOException, + ExecutionException { + LedgerOffloader offloader = offloaderGenerator.getOffloader( + new HashMap<String, String>() {{ + put(TieredStorageConfiguration.MAX_OFFLOAD_SEGMENT_SIZE_IN_BYTES, "1000"); + put(offloaderGenerator.getConfig().getKeys(TieredStorageConfiguration.METADATA_FIELD_MAX_BLOCK_SIZE) + .get(0), "5242880"); + put(TieredStorageConfiguration.MAX_OFFLOAD_SEGMENT_ROLLOVER_TIME_SEC, "600"); + put("offloadMethod", OffloadPolicies.OffloadMethod.STREAMING_BASED.getStrValue()); + }} + ); + int ENTRIES_PER_LEDGER = 10; + ManagedLedgerConfig config = new ManagedLedgerConfig(); + config.setMaxEntriesPerLedger(ENTRIES_PER_LEDGER); + config.setMinimumRolloverTime(0, TimeUnit.SECONDS); + config.setRetentionTime(10, TimeUnit.MINUTES); + config.setRetentionSizeInMB(10); + config.setLedgerOffloader(offloader); + + ManagedLedgerImpl ledger = (ManagedLedgerImpl) factory.open("test_read_and_write", config); + + for (int i = 0; i < ENTRIES_PER_LEDGER * 2.5; i++) { + String content = "entry-" + i; + ledger.addEntry(content.getBytes()); + } + final LedgerOffloader.OffloadHandle currentOffloadHandle = ledger.getCurrentOffloadHandle(); + currentOffloadHandle.close(); + final LedgerOffloader.OffloadResult offloadResult = currentOffloadHandle.getOffloadResultAsync().get(); + log.info("offloadResult = " + offloadResult); + log.info("offload method: " + ledger.getOffloadMethod()); + + Awaitility.await().untilAsserted( + () -> Assert.assertTrue(isStreamingOffloadCompleted(ledger.getLedgersInfoAsList().get(0)))); + Assert.assertTrue(isStreamingOffloadCompleted(ledger.getLedgersInfoAsList().get(0))); + Assert.assertTrue(isStreamingOffloadCompleted(ledger.getLedgersInfoAsList().get(1))); + + ManagedCursor cursor = ledger.newNonDurableCursor(PositionImpl.earliest); + int i = 0; + for (Entry e : cursor.readEntries(10)) { + assertEquals(new String(e.getData()), "entry-" + i++); + } + + for (Entry e : cursor.readEntries(10)) { + assertEquals(new String(e.getData()), "entry-" + i++); + } + + for (Entry e : cursor.readEntries(5)) { + assertEquals(new String(e.getData()), "entry-" + i++); + } + } + + @Test + public void testSetStreamingOffloadAfterCreated() throws ManagedLedgerException, InterruptedException, IOException, + ExecutionException { + LedgerOffloader offloader = offloaderGenerator.getOffloader( + new HashMap<String, String>() {{ + put(TieredStorageConfiguration.MAX_OFFLOAD_SEGMENT_SIZE_IN_BYTES, "1000"); + put(offloaderGenerator.getConfig().getKeys(TieredStorageConfiguration.METADATA_FIELD_MAX_BLOCK_SIZE) + .get(0), "5242880"); + put(TieredStorageConfiguration.MAX_OFFLOAD_SEGMENT_ROLLOVER_TIME_SEC, "600"); + put("offloadMethod", OffloadPolicies.OffloadMethod.LEDGER_BASED.getStrValue()); + }} + ); + int ENTRIES_PER_LEDGER = 10; + ManagedLedgerConfig config = new ManagedLedgerConfig(); + config.setMaxEntriesPerLedger(ENTRIES_PER_LEDGER); + config.setMinimumRolloverTime(0, TimeUnit.SECONDS); + config.setRetentionTime(10, TimeUnit.MINUTES); + config.setRetentionSizeInMB(10); + config.setLedgerOffloader(offloader); + + ManagedLedgerImpl ledger = (ManagedLedgerImpl) factory.open("test_read_and_write", config); + int beforeSetStreaming = 1; + for (int i = 0; i < beforeSetStreaming; i++) { + String content = "entry-" + i; + ledger.addEntry(content.getBytes()); + } + + LedgerOffloader streamingOffloader = offloaderGenerator.getOffloader( + new HashMap<String, String>() {{ + put(TieredStorageConfiguration.MAX_OFFLOAD_SEGMENT_SIZE_IN_BYTES, "1000"); + put(offloaderGenerator.getConfig().getKeys(TieredStorageConfiguration.METADATA_FIELD_MAX_BLOCK_SIZE) + .get(0), "5242880"); + put(TieredStorageConfiguration.MAX_OFFLOAD_SEGMENT_ROLLOVER_TIME_SEC, "600"); + put("offloadMethod", OffloadPolicies.OffloadMethod.STREAMING_BASED.getStrValue()); + }} + ); + + config.setLedgerOffloader(streamingOffloader); + ledger.setConfig(config); + + for (int i = beforeSetStreaming; i < ENTRIES_PER_LEDGER * 2.5; i++) { + String content = "entry-" + i; + ledger.addEntry(content.getBytes()); + } + + Awaitility.await().atMost(Duration.ofSeconds(30)).untilAsserted(() -> { + final LedgerOffloader.OffloadHandle before = ledger.getCurrentOffloadHandle(); + Thread.sleep(5000); Review comment: I tried pullInterval but due to Java Lamba's limited ability it seems I have to use the current way. ```java final LedgerOffloader.OffloadHandle currentOffloadHandle = ledger.getCurrentOffloadHandle(); Awaitility.await().pollDelay(Duration.ofSeconds(5)).pollInterval(Duration.ofSeconds(5)).untilAsserted(() -> { final LedgerOffloader.OffloadHandle old = currentOffloadHandle; currentOffloadHandle = ledger.getCurrentOffloadHandle(); Assert.assertSame(old, currentOffloadHandle); }); ``` <img width="1007" alt="image" src="https://user-images.githubusercontent.com/3381789/106861227-72494f00-6700-11eb-9d68-7fac3a4a4bdc.png";> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
![https://user-images.githubusercontent.com/3381789/106861227-72494f00-6700-11eb-9d68-7fac3a4a4bdc.png"](https://user-images.githubusercontent.com/3381789/106861227-72494f00-6700-11eb-9d68-7fac3a4a4bdc.png"){kind=link}