Renkai commented on a change in pull request #9202:
URL: https://github.com/apache/pulsar/pull/9202#discussion_r569196315
##########
File path:
pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPolicies.java
##########
@@ -148,6 +200,11 @@ public String getValue() {
@Configuration
@JsonProperty(access = JsonProperty.Access.READ_WRITE)
private OffloadedReadPriority managedLedgerOffloadedReadPriority =
DEFAULT_OFFLOADED_READ_PRIORITY;
+ @Configuration
+ private OffloadMethod offloadMethod = DEFAULT_OFFLOAD_METHOD;
Review comment:
As far as I know, they can be initialized here by java reflections as
long as the enum can be initialized by a one-string parameter constructor
https://github.com/apache/pulsar/blob/dfcea855615a732e6f7ae029436ac9e1a0c71a61/pulsar-common/src/main/java/org/apache/pulsar/common/policies/data/OffloadPolicies.java#L674
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
