lizhimins commented on issue #155: URL: https://github.com/apache/rocketmq-flink/issues/155#issuecomment-6580154894
Progress on the four steps: 1. **Migrate `main` to the new API only, staying on Flink 1.20.3 / Java 11** — done in #157, merged as [`0b3ae9d`](https://github.com/apache/rocketmq-flink/commit/0b3ae9d82cb35012d5ab9b4cc18dd47f1147dbe7). 2. **Cut the 1.x maintenance branch at that merge commit** — done: [`v3.0`](https://github.com/apache/rocketmq-flink/tree/v3.0) points at `0b3ae9d`. 3. **Switch `main` to Flink 2.2.1 / Java 17 in a single follow-up commit** — #158. The diff between `v3.0` and `main` is exactly that one commit, so a fix cherry-picks both ways without adaptation in the shared code. 4. **Propagate fixes by cherry-pick** — nothing to propagate yet: #154 landed before the split, so both lines already carry it. Two things worth recording for whoever cuts the next release: - Both lines currently carry project version `3.0.0`, so the artifacts would collide on the same GAV with different content. Following the flink-connector-kafka convention, release artifacts should carry the Flink version as a second segment (`3.0.0-1.20` from `v3.0`, `3.0.0-2.2` from `main`). - spotless-maven-plugin 2.27.1 **silently skips** its Java formatter on JDK 16+ (the log line is `Spotless check skipped`), so a `spotless:check` step inside a JDK 17 job enforces nothing. Once the build matrix is JDK-17-only, the style gate has to run on a JDK 11 job — #158 does that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
