forgivemyheart opened a new issue, #639:
URL: https://github.com/apache/rocketmq-clients/issues/639

   ### Before Creating the Bug Report
   
   - [X] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq-clients/discussions).
   
   - [X] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq-clients/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq-clients/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [X] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Programming Language of the Client
   
   C++
   
   ### Runtime Platform Environment
   
   all
   
   ### RocketMQ Version of the Client/Server
   
   all 
   
   ### Run or Compiler Version
   
   _No response_
   
   ### Describe the Bug
   
   void SimpleConsumerImpl::topicsOfInterest(std::vector<std::string> topics) {
     absl::MutexLock lk(&subscriptions_mtx_);
     for (const auto& entry : subscriptions_) {
       if (std::find(topics.begin(), topics.end(), entry.first) == 
topics.end()) {
         topics.push_back(entry.first);
       }
     }
   }
   
   Based on the topicsOfInterest function's intention, which is to modify the 
input parameter, it should pass a reference instead of a value.
   
   ### Steps to Reproduce
   
   code error
   
   ### What Did You Expect to See?
   
   Input parameters are modified correctly
   
   ### What Did You See Instead?
   
   The input parameters have not been modified
   
   ### Additional Context
   
   _No response_


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscr...@rocketmq.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to