RongtongJin commented on code in PR #9549:
URL: https://github.com/apache/rocketmq/pull/9549#discussion_r2329934728
##########
common/src/main/java/org/apache/rocketmq/common/BrokerConfig.java:
##########
@@ -141,6 +142,9 @@ public class BrokerConfig extends BrokerIdentity {
private boolean slaveReadEnable = false;
+ @JSONField(serialize = false)
+ private boolean routeEventServiceEnable = true;
Review Comment:
这个开关叫做enableRouteChangeNotification，且应该放在发送路由事件时，而不应该是在启动服务时
##########
proxy/src/main/java/org/apache/rocketmq/proxy/service/route/TopicRouteService.java:
##########
@@ -134,9 +150,68 @@ public String resolve(String name) {
}
}
}, serviceDetector);
+
+ if (config.isBrokerRouteEventServiceEnable()) {
Review Comment:
同理，开关不应该是否能初始化，而应该是实际作用是否生效，这样才能在运行时做修改
##########
proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java:
##########
@@ -207,6 +208,9 @@ public class ProxyConfig implements ConfigFile {
private boolean enableAclRpcHookForClusterMode = false;
+ @JSONField(serialize = false)
Review Comment:
不需要加json注解
##########
proxy/src/main/java/org/apache/rocketmq/proxy/config/ProxyConfig.java:
##########
@@ -207,6 +208,9 @@ public class ProxyConfig implements ConfigFile {
private boolean enableAclRpcHookForClusterMode = false;
+ @JSONField(serialize = false)
+ private boolean brokerRouteEventServiceEnable = true;
Review Comment:
也叫enableRouteChangeNotification
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
