majialoong commented on code in PR #10499: URL: https://github.com/apache/rocketmq/pull/10499#discussion_r3413684591
########## docs/cn/acl/user_guide.md: ########## @@ -48,6 +49,12 @@ storePathCommitLog=/data/rocketmq/commitlog-a-m autoCreateSubscriptionGroup=true ## if acl is open,the flag will be true aclEnable=true +## RocketMQ 5.x 需要额外配置以下ACL属性 +authenticationEnabled=true +authorizationEnabled=true +migrateAuthFromV1Enabled=true Review Comment: I think `migrateAuthFromV1Enabled` is not necessary here, since it is only required when migrating from ACL v1 to ACL v2. ########## docs/cn/acl/user_guide.md: ########## @@ -48,6 +49,12 @@ storePathCommitLog=/data/rocketmq/commitlog-a-m autoCreateSubscriptionGroup=true ## if acl is open,the flag will be true aclEnable=true +## RocketMQ 5.x 需要额外配置以下ACL属性 +authenticationEnabled=true +authorizationEnabled=true +migrateAuthFromV1Enabled=true +authenticationMetadataProvider=org.apache.rocketmq.auth.authentication.provider.LocalAuthenticationMetadataProvider +authorizationMetadataProvider=org.apache.rocketmq.auth.authorization.provider.LocalAuthorizationMetadataProvider listenPort=10911 Review Comment: Maybe we should also add the default authentication and authorization providers here for completeness: ``` authenticationProvider=org.apache.rocketmq.auth.authentication.provider.DefaultAuthenticationProvider authorizationProvider=org.apache.rocketmq.auth.authorization.provider.DefaultAuthorizationProvider ``` ########## docs/en/acl/Operations_ACL.md: ########## @@ -47,6 +48,12 @@ storePathCommitLog=/data/rocketmq/commitlog-a-m autoCreateSubscriptionGroup=true ## if acl is open,the flag will be true aclEnable=true +## RocketMQ 5.x requires the following additional ACL properties +authenticationEnabled=true +authorizationEnabled=true +migrateAuthFromV1Enabled=true Review Comment: ditto. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
