RockteMQ-AI commented on PR #10567: URL: https://github.com/apache/rocketmq/pull/10567#issuecomment-4857092077
## Review by github-manager-bot (Re-review after new commit) ### Summary Re-reviewed after commit `2279a41` (2026-07-01T05:52Z). The change adds a `counter > popCkMaxBufferSize` guard to `addCkJustOffset()`, mirroring the existing check in `addCk()`. ### Assessment: ✅ Looks Good - **Correctness** — The guard is consistent with `addCk()`. Returns `false` on overflow, matching callers that already handle this case. - **Thread safety** — `counter.get()` is an `AtomicLong` read; `popCkMaxBufferSize` is a config read. No new race conditions introduced. The check is best-effort (not strictly bounding), which is acceptable for a buffer overflow guard. - **Logging** — Warning log includes the checkpoint and current counter value, useful for debugging. - **Test** — `testAddCkJustOffsetMaxSize` correctly verifies boundary: first add succeeds (0 > 0 = false), second is rejected (1 > 0 = true). No new issues found. The fix is minimal, targeted, and well-tested. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
