wang-jiahua commented on code in PR #10566:
URL: https://github.com/apache/rocketmq/pull/10566#discussion_r3510560004
##########
store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java:
##########
@@ -1271,7 +1279,13 @@ public void initializeWithOffset(long offset, long
minPhyOffset) {
// transientStorePool is null, only need set wrote position here
MappedFile mappedFile = mappedFileQueue.getLastMappedFile(offset *
ConsumeQueue.CQ_STORE_UNIT_SIZE, true);
- fillPreBlank(mappedFile, offset * ConsumeQueue.CQ_STORE_UNIT_SIZE);
+ if (mappedFile != null && mappedFile.hold()) {
+ try {
Review Comment:
Fixed in the latest commit. Instead of silently skipping `fillPreBlank()`,
the method now logs an error and returns early when `mappedFile` is null or
`hold()` fails, preventing the consume queue from being left in an inconsistent
state.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
