Copilot commented on code in PR #10566:
URL: https://github.com/apache/rocketmq/pull/10566#discussion_r3503196304
##########
store/src/main/java/org/apache/rocketmq/store/ConsumeQueue.java:
##########
@@ -1271,7 +1279,13 @@ public void initializeWithOffset(long offset, long
minPhyOffset) {
// transientStorePool is null, only need set wrote position here
MappedFile mappedFile = mappedFileQueue.getLastMappedFile(offset *
ConsumeQueue.CQ_STORE_UNIT_SIZE, true);
- fillPreBlank(mappedFile, offset * ConsumeQueue.CQ_STORE_UNIT_SIZE);
+ if (mappedFile != null && mappedFile.hold()) {
+ try {
Review Comment:
`initializeWithOffset` now silently skips `fillPreBlank` when `mappedFile`
is null or `hold()` fails. Previously this would fail fast (NPE), which is
safer because this method relies on the consume-queue files being continuous;
skipping the pre-blank initialization can leave the queue in an inconsistent
state and make the root cause (file creation/availability failure) hard to
diagnose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
