Aias00 opened a new pull request, #10686:
URL: https://github.com/apache/rocketmq/pull/10686

   ### Which Issue(s) This PR Fixes
   
   Fixes #10685
   
   ### Brief Description
   
   `GrpcConverter.buildSystemProperties` previously parsed 
`PROPERTY_TIMER_DELAY_SEC` and `PROPERTY_TIMER_DELIVER_MS` with 
`Long.parseLong` directly. If either optional timer property was malformed, 
converting a Broker `MessageExt` to the gRPC v2 `Message` response could throw 
`NumberFormatException`.
   
   This PR adds safe parsing for those timer properties. Valid values still 
populate `delivery_timestamp`; malformed values are ignored with a warning so 
the message conversion can continue.
   
   ### How Did You Test This Change?
   
   ```bash
   mvn -pl proxy -Dtest=GrpcConverterTest -DfailIfNoTests=false test
   ```
   
   Result: `BUILD SUCCESS`, `Tests run: 6, Failures: 0, Errors: 0, Skipped: 0`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to