Aias00 commented on PR #10689: URL: https://github.com/apache/rocketmq/pull/10689#issuecomment-5117885100
Addressed the review suggestion in the latest commit:\n\n- Changed `TopicRouteWrapper.getMasterAddr` to return `Optional<String>`.\n- Updated `MessageQueueSelector.buildWrite` to explicitly skip route entries without a master broker address.\n- Updated `ClusterTopicRouteService.getBrokerAddr` to convert a missing master broker address into `ProxyExceptionCode.INVALID_BROKER_NAME` instead of returning `null`.\n- Added regression coverage for unknown broker `Optional.empty()`, normal queue-data skip behavior, and the ClusterTopicRouteService domain exception.\n\nLocal verification passed:\n`mvn -pl proxy -Dtest=MessageQueueSelectorTest,ClusterTopicRouteServiceTest -DfailIfNoTests=false test` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
