Aias00 commented on PR #10689: URL: https://github.com/apache/rocketmq/pull/10689#issuecomment-5138009404
Added one more regression commit for the exceptional future propagation part of the review feedback. New coverage in `ClusterMessageServiceTest` asserts that broker lookup failures complete returned futures exceptionally for both paths: - `ClusterMessageService.request(...)` - `ClusterMessageService.requestOneway(...)` Both tests verify the propagated `ProxyExceptionCode.INVALID_BROKER_NAME`, so the invalid broker-name path does not proceed to remoting with a missing address. Local verification with JDK 8: `JAVA_HOME=$(/usr/libexec/java_home -v 1.8) mvn -pl proxy -Dtest=MessageQueueSelectorTest,ClusterTopicRouteServiceTest,ClusterMessageServiceTest -DfailIfNoTests=false test` Result: `Tests run: 14, Failures: 0, Errors: 0, Skipped: 0`; checkstyle and spotbugs also passed in the same run. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
