RockteMQ-AI commented on issue #1391: URL: https://github.com/apache/rocketmq-dashboard/issues/1391#issuecomment-5236151208
**Issue Evaluation** Category: `bug` | Status: **Confirmed** The bug is valid. `MybatisPlusSettingsRepository` catches JSON deserialization failures for persisted general settings and silently returns defaults. After a storage corruption event, operators see what appears to be a valid configuration but is actually the fallback — security-related settings may appear disabled when they were previously enabled. **Root Cause:** Overly broad exception handling that masks corruption by returning defaults. **Impact:** Silent configuration reset after storage corruption — operators cannot distinguish first-run defaults from damaged state. **Severity:** Medium — particularly concerning for security-related settings. Surfacing corruption as a structured error while keeping defaults for absent records (as proposed) is the correct approach. --- *Automated evaluation by RockteMQ-AI* -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
