RockteMQ-AI commented on issue #1387:
URL: 
https://github.com/apache/rocketmq-dashboard/issues/1387#issuecomment-5236154738

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The bug is valid. Data source creation/update accepts any non-empty `type` 
value. Later, `MetricsBackendType` silently treats unknown provider types as 
Prometheus, so a typo (e.g., `"promethus"`) or unsupported provider is 
persisted with behavior different from its configuration intent.
   
   **Root Cause:** Missing validation of provider type at the 
service/controller layer; silent fallback in `MetricsBackendType`.
   **Impact:** Operators save a configuration that appears to target one 
backend but is queried through Prometheus paths — silent misconfiguration.
   **Severity:** Medium — affects Metrics configuration reliability and can 
cause confusing query failures.
   
   Validating and normalizing supported provider types at create/update time 
(as proposed) is the correct fix.
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to