tju-yxq opened a new pull request, #1438: URL: https://github.com/apache/rocketmq-dashboard/pull/1438
## What is the purpose of the change Fixes #1437 `RocketMQClusterProvider.parseFirstTpsValue()` returned `parts[0]` as `int` (10-minute average), while `RocketMQDashboardProvider.parseTps()` returned `parts[1]` as `long` (1-minute average). The cluster detail page and dashboard showed different TPS values for the same broker. ## Brief changelog - **`RocketMQClusterProvider.java`**: Renamed `parseFirstTpsValue` to `parseTpsValue`, changed to return `parts[1]` (1-minute average) as `long`, matching `DashboardProvider.parseTps()`. ## Verifying this change 1. Compare TPS values between dashboard overview and cluster detail page. 2. Before fix: different values (10min avg vs 1min avg). 3. After fix: same values (both 1min avg). - [x] Make sure there is a Github issue filed for the change. - [x] Format the pull request title like `[ISSUE #1437] ...`. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
