tju-yxq opened a new pull request, #1442: URL: https://github.com/apache/rocketmq-dashboard/pull/1442
## What is the purpose of the change Fixes #1441 The reset offset endpoint did not validate the `topic` field, causing HTTP 500 with a confusing internal error when topic was omitted. ## Brief changelog - **`ResetConsumerOffsetDTO.java`**: Added `@NotBlank(message = "topic is required")` to the `topic` field. - **`RocketMQAdminClientImpl.java`**: Added `StringUtils.hasText(topic)` check in `resetOffset()`, throwing `BusinessException(400, "topic is required for offset reset")`. ## Verifying this change 1. Call reset-offset without topic. 2. Before fix: HTTP 500 with confusing error. 3. After fix: HTTP 400 with "topic is required for offset reset". - [x] Make sure there is a Github issue filed for the change. - [x] Format the pull request title like `[ISSUE #1441] ...`. - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [x] Write necessary unit-test to verify your logic correction. - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. - [ ] If this contribution is large, please file an Apache Individual Contributor License Agreement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
