RockteMQ-AI commented on code in PR #2308:
URL:
https://github.com/apache/rocketmq-dashboard/pull/2308#discussion_r3795290803
##########
server/src/main/java/org/apache/rocketmq/studio/provider/apache/RocketMQDLQProvider.java:
##########
@@ -90,9 +96,14 @@ private List<DLQGroupVO> listDLQGroups(MQAdminExt adminExt)
throws Exception {
if (!StringUtils.hasText(groupName)) {
continue;
}
- groups.add(buildDLQGroup(adminExt, groupName, topic));
+ if (search == null || groupName.contains(search) ||
topic.contains(search)) dlqTopics.add(topic);
Review Comment:
The DLQ pagination is implemented as in-memory filtering and slicing after
fetching all topics. This is acceptable for moderate topic counts, but if the
number of DLQ topics grows large (1000+), consider pushing the filtering down
to the broker query or adding a cache layer to avoid repeated full topic list
fetches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
