RockteMQ-AI commented on issue #10972:
URL: https://github.com/apache/rocketmq/issues/10972#issuecomment-5437463800

   **Issue Evaluation**
   
   Category: `bug` | Status: **Confirmed**
   
   The reported issue has been verified against the current codebase.
   
   **Root Cause:** In `TimerMessageStore#convertMessage` (line 1255), 
`setPropertiesString(MessageDecoder.messageProperties2String(msgExt.getProperties()))`
 encodes ALL properties — including `PROPERTY_REAL_TOPIC` and 
`PROPERTY_REAL_QUEUE_ID` — into the properties string. Then at lines 1268-1271, 
`clearProperty` removes those keys from the properties **map**, but the 
**propertiesString** (which is what gets persisted and transmitted) still 
contains the stale encoded values.
   
   **Impact:** When a timer message is rolled/dispatched, the persisted 
propertiesString carries stale `REAL_TOPIC`/`REAL_QUEUE_ID` from the original 
scheduling. If downstream code re-parses the propertiesString, it may see 
incorrect routing metadata.
   
   **Severity:** Medium — affects timer message dispatch correctness in edge 
cases where propertiesString is re-parsed.
   
   **Fix direction:** Move `setPropertiesString` **after** the `clearProperty` 
calls, or rebuild the propertiesString from the cleaned properties map.
   
   An automated fix proposal can be generated. Reply `/approve` to proceed with 
PR generation.
   
   ---
   *Automated evaluation by RockteMQ-AI*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to