lizhimins commented on code in PR #11086:
URL: https://github.com/apache/rocketmq/pull/11086#discussion_r3965015588
##########
test/src/test/java/org/apache/rocketmq/test/offset/OffsetResetForPopIT.java:
##########
@@ -77,7 +82,16 @@ public void setUp() throws Exception {
@After
public void tearDown() {
- shutdown();
+ try {
+ if (consumerStarted) {
+ consumer.shutdown();
+ }
+ } finally {
+ shutdown();
+
brokerController1.getBrokerConfig().setUseServerSideResetOffset(useServerSideResetOffset);
Review Comment:
这个改法有点太奇怪了，broker controller 在这里其实都可以是 mock 的对象
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
