unbridled-41 commented on PR #4566:
URL: 
https://github.com/apache/rocketmq-dashboard/pull/4566#issuecomment-5747181888

   ## Verification evidence
   
   **CI (current head)**: head SHA `5df2bf9c90d1fff5085841cd40ef2c8ca2dd32cc` 
has exactly one workflow run — "CI" (pull_request), run id 35484380352, 
conclusion `startup_failure`, and 0 check-runs on the head commit (upstream CI 
fails at startup for every branch/PR, including maintainers'; 
infrastructure-level, not caused by this change). Local verification below 
substitutes for it.
   
   **Red (baseline = master `d50ffecc` + the two new tests, fix stashed)**: 
`mvn -o test -Dtest=RocketMQLiteTopicProviderTest` → `Tests run: 15, Failures: 
2, Errors: 0` —
   - `listLiteTopicsSkipsAMasterWhoseLiteInfoFailsInsteadOfFailingThePage` — 
`IllegalStateException: broker restarting` escaped the admin action instead of 
being skipped;
   - `quotaSkipsAMasterWhoseLiteInfoFailsInsteadOfFailingThePage` — same escape 
in the quota loop.
   
   (An initial combined run before scoping also carried the capability-probe 
twin; that test was moved to the separate #4568 to keep one defect per PR — the 
scoped red run on this branch's final test set is `Tests run: 15, Failures: 2`.)
   
   **Module (green)**: `mvn -o test -Dtest=RocketMQLiteTopicProviderTest` → 
**16/16 passed, 0 failures, 0 errors**; related modules `LiteTopicServiceTest` 
10/10 and `LiteTopicControllerTest` 8/8.
   
   **Full suite + baseline**: `SPRING_PROFILES_ACTIVE=dev mvn -o clean test` on 
this exact tree → **`Tests run: 2416, Failures: 0, Errors: 0, Skipped: 0`, 
BUILD SUCCESS** (XML surefire basis). Pristine `origin/master` `d50ffecc` in a 
clean worktree on the identical basis: **2414 tests, 0 failures** — the +2 
delta is exactly the two new regression tests. Zero new failures.
   
   **Build**: `mvn -o checkstyle:check` → **0 violations**, BUILD SUCCESS 
(compilation covered by the full `clean test` run).
   
   **Diff self-check (`git show --numstat HEAD`)**: `19/2 
server/.../provider/apache/RocketMQLiteTopicProvider.java`, `44/0 
server/.../provider/apache/RocketMQLiteTopicProviderTest.java` — 2 files, 
+63/−2, no unrelated changes.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to