X-LightYear opened a new pull request, #5135:
URL: https://github.com/apache/rocketmq-dashboard/pull/5135

   ## Summary
   
   - keep failed audit-summary requests out of the zero-valued statistics cards
   - show an explicit localized unavailable state while preserving the record 
table
   - add a deterministic page regression for summary failure with successful 
records
   
   ## Root cause
   
   `AuditPage` left `summary` as `null` when `getAuditSummary` failed. After 
loading ended, `AuditSummaryCards` treated `null` as an empty aggregate and 
rendered zero matching records, zero operators, and a 0% success rate.
   
   ## Fix
   
   Track summary request failure separately from an empty successful summary. 
The summary cards now render a localized error state when the aggregate is 
unavailable; filter changes and successful responses clear that state.
   
   ## Testing
   
   - pre-fix regression: `AuditPage > reports an unavailable summary instead of 
rendering zero statistics` failed because the page rendered no unavailable 
state and fell back to zero statistics
   - post-fix focused regression: 1 passed
   - `AuditPage.test.tsx` + `AuditSummaryCards.test.tsx`: 15 passed
   - relevant ESLint: passed
   - `git diff --check`: passed
   - TypeScript and Vite build stages completed
   - repository distribution-license gate: environment/dependency failure for 
`toggle-selection` verified license text
   
   Fixes #4599


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to