Frun1na commented on PR #4852: URL: https://github.com/apache/rocketmq-dashboard/pull/4852#issuecomment-5936516498
Rebased onto the head that already contains the merged workspace half (#4754), so this PR no longer touches the workspace deletion itself: what remains is the run-stopping half. - `deleteCascade` stops a run the registry still owns before the rows disappear, and the abort now carries its own `AbortReason.RETENTION` with a matching `StopReason.RETENTION`; a retention sweep is server-asked like `SHUTDOWN`, so the run is `STOPPED` rather than `FAILED`, and `ORPHANED` keeps meaning "no live owner", which is not this case. - The `AbortReason` javadoc's path-to-reason list names the retention sweep, and the two documents that enumerate the stop reasons (`docs/api-spec.md` and `docs/ai-agent-architecture.md`) plus the web `StopReason` union were updated in the same change. - The test is now discriminating: `AgentRunRegistry` is a `@MockitoSpyBean` and `theRetentionSweepShouldStopALiveRunBeforeDeletingTheConversationTest` verifies `stop(runId, RETENTION)`, which fails on a revert of the stop call. The workspace test is kept, since it pins the behaviour that landed in #4754 and that half shipped without one. Verification: `mvn -B -ntp -DforkCount=1 -Dtest=AgentRunHandleStopTest test` (9/9), and the two aiEvents vitest files with the new `RETENTION` member (the coverage map now expects 9 stop reasons). The persistence integration test needs MySQL, which this environment does not have, so it runs on CI only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
