The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/audit-export-error-reason has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
323f3e2f1f83d683aa7fb4890cf66296a3a40154 / unbridled-41 
<[email protected]>
fix(audit): surface the export cap instead of advising a retry that cannot work

GET /audit-logs/export refuses any filtered result set above
AuditService.MAX_EXPORT_RECORDS with

    400 {"code":400,"message":"Audit log export exceeds the maximum of 10000
    records; narrow the filters"}

The audit page's export handler caught the failure without the error object and
showed its generic "导出审计日志失败,请稍后重试" ("... try again later"), which is
advice that can never succeed: the same filters produce the same 400. The one
actionable fact - narrow the filters - is the only thing the toast drops.

The utilities the fix needs already exist: exportAuditLogs is a JSON call, so
error.response.data.message carries the reason, and describeApiError is the
shared extractor the alert and instance pages use for exactly this (they surface
alert-rule import conflicts the same way). Fall back to the existing string when
the failure carries no server message.

Tests (web/): npx vitest run src/pages/ops/__tests__/AuditPage.test.tsx
- new case "surfaces the export cap instead of telling the user to retry" fails
  before this change (the cap message is absent and the generic toast is shown)
  and passes after it; 12 tests in the file pass.
- npx eslint on both files reports no errors; npx tsc -b passes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37960166508

With regards,
GitHub Actions via GitBox

Reply via email to