The GitHub Actions job "CI" on 
rocketmq-dashboard.git/fix/group-update-delivery-order has failed.
Run started by GitHub user unbridled-41 (triggered by unbridled-41).

Head commit for run:
8daf0367fe7fa43bdbb89a8e7008b0d67b7ea258 / unbridled-41 
<[email protected]>
fix(group): apply the requested delivery order type when a group is updated

createConsumerGroup reaches the broker for `consumeMessageOrderly` (commit 
#4839,
"The create form submits the ordered spelling of the group's delivery order 
type,
and consumeMessageOrderly is the very flag the group settings dialog reads and
writes"), but updateConsumerGroup wrote only the retry limit:

    for (Map.Entry<String, SubscriptionGroupConfig> entry : configs.entrySet()) 
{
        SubscriptionGroupConfig config = entry.getValue();
        config.setRetryMaxTimes(group.getRetryMaxTimes());
        admin.createAndUpdateSubscriptionGroupConfig(entry.getKey(), config);
    }

`deliveryOrderType` is part of the update request the AI tool contract 
advertises
(GroupInput, and the plan's before/after show the switch), so asking for ordered
consumption returned a successful update while the brokers kept the previous 
flag -
ordered consumption on a FIFO topic silently did not happen, and nothing 
recorded
that the field was dropped.

Apply it symmetrically with the create path when the request carries a value, 
and
keep the broker's own flag when it does not; the audit detail names both 
outcomes.

Tests (server/): mvn -o -B -ntp test -Dtest='RocketMQAdminClientImplTest'
-> Tests run: 82, Failures: 0, Errors: 0.
- new updateConsumerGroupAppliesTheRequestedDeliveryOrderTypeTest fails before 
this
  change ("Expecting value to be true but was false") and passes after it.
- updateConsumerGroupKeepsTheBrokerFlagWhenNoDeliveryOrderTypeIsRequestedTest
  guards the absent case.
- mvn -o -B -ntp test 
-Dtest='org.apache.rocketmq.studio.instance.group.**,RocketMQMetadataProviderTest'
  -> Tests run: 81, Failures: 0, Errors: 0; checkstyle passes.

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/37981649403

With regards,
GitHub Actions via GitBox

Reply via email to