The GitHub Actions job "CI" on rocketmq-dashboard.git/fix/batch-delete-cap has 
failed.
Run started by GitHub user Frun1na (triggered by Frun1na).

Head commit for run:
5632d35a4f1584ae94e5cb3d048e91e52abf5117 / Apulupie 
<[email protected]>
fix(instance): bound the batch delete like every other batch input

fix(instance): bound the batch delete like every other batch input

`BatchDeleteInstancesDTO.ids` carried only `@NotEmpty`, and 
`InstanceService.deleteInstances` looped
over the list without a cap: every id costs one identifier lookup and one 
transactional delete through
`self.deleteInstance`, so an unbounded list is a request whose side effects are 
partial when it times
out. The repository caps every other batch input at 100 - import topics, import 
consumer groups and
selected DLQ resends - with the same reasoning, on the DTO and again in the 
service.

The DTO now declares the cap and the service enforces it for non-REST callers 
as well; the console
only submits the rows of one page (at most 100), so no existing flow is 
affected.

InstanceServiceTest + InstanceControllerTest: 113 tests green, 0 checkstyle 
violations. Both new
tests fail on the unfixed code (the controller answers 200 with an overloaded 
batch).

Report URL: 
https://github.com/apache/rocketmq-dashboard/actions/runs/38038992467

With regards,
GitHub Actions via GitBox

Reply via email to