123123213weqw commented on PR #5725: URL: https://github.com/apache/rocketmq-dashboard/pull/5725#issuecomment-6123353578
@lizhimins I stopped short of refreshing this one, because it now collides head-on with #6144, merged earlier today: that change removed `popProgress` from `LiteTopicSession`/`LiteTopicSessionVO`/`LiteTopicSessionOutput`/`litetopic.yaml`/`LiteTopic.tsx` precisely because nothing on the server ever computed it — while this PR's whole point is to start computing it (`popProgressPercent` in `LiteTopicService`) and map it into the session view. Merged onto the current base as-is, the branch no longer compiles (`LiteTopicSessionVOBuilder.popProgress` is gone). So the direction needs your call before I touch anything: - if the field should come back now that something actually computes it, I'll revive the full chain this PR needs on top of the new base — VO + `LiteTopicSessionOutput` + `litetopic.yaml` + regenerated catalog digest + the `LiteTopic.tsx` panel and the `liteTopic.popProgress` i18n pair that #6144 removed; or - if #6144's removal stands, this PR is obsolete and I'll close it. Say which and it's done either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
