hickey-ai opened a new issue, #11461:
URL: https://github.com/apache/rocketmq/issues/11461

   ### Before Creating the Bug Report
   
   - [x] I found a bug, not just asking a question, which should be created in 
[GitHub Discussions](https://github.com/apache/rocketmq/discussions).
   
   - [x] I have searched the [GitHub 
Issues](https://github.com/apache/rocketmq/issues) and [GitHub 
Discussions](https://github.com/apache/rocketmq/discussions)  of this 
repository and believe that this is not a duplicate.
   
   - [x] I have confirmed that this bug belongs to the current repository, not 
other repositories of RocketMQ.
   
   
   ### Runtime platform environment
   
   Windows 11; local file utility tests using unique temporary filenames and 
cleanup. No broker deployment is required.
   
   ### RocketMQ version
   
   develop, revision 5.5.1, commit 57c2dc04f78cc7e73e6b8c9436ee0fff0d0f46c3.
   
   ### JDK Version
   
   OpenJDK 1.8.0_302 (GraalVM CE 21.2.0), Maven 3.6.3.
   
   ### Describe the Bug
   
   copyFile(source, "copy.bin") constructs a File for the target and 
unconditionally calls tf.getParentFile().mkdirs(). A bare relative filename has 
no parent File, so copying fails with NullPointerException before any bytes are 
copied. Both new and existing target files are affected.
   
   ### Steps to Reproduce
   
   1. Create an ordinary source file with known bytes.
   2. Call IOTinyUtils.copyFile(source.toString(), "copy-unique-name.bin") with 
a filename that has no directory component.
   3. Repeat with an already existing bare target filename.
   4. Remove the unique test target in finally.
   
   Both calls fail at the getParentFile().mkdirs() line; an absolute or nested 
target is the control case.
   
   ### What Did You Expect to See?
   
   A bare filename is a valid target in the current working directory. New 
files should be copied, existing files overwritten with the source bytes, and 
nested target directories should still be created when present.
   
   ### What Did You See Instead?
   
   NullPointerException at IOTinyUtils.copyFile line 84, before the copy starts.
   
   ### Additional Context
   
   The minimal correction only guards the optional parent directory. Four new 
regression methods cover new/overwritten relative targets, nested directory 
creation, and preserving an existing target when the source is missing. Two 
bare-target cases fail before the correction; all four pass after. The 
independent native common run executes the 8 existing IOTinyUtilsTest tests 
plus the 4 new tests: 12 passed, 0 failures/errors/skips, with 
Checkstyle/SpotBugs passing.
   
   #10208 and PR #10210 concern resource closure in the same method, but their 
diff does not change the null-parent call. PR #10733 does not modify 
IOTinyUtils. No matching discussion or relative-target fix was found in the 
reviewed results.
   
   AI assistance: OpenAI Codex was used for investigation, implementation and 
tests.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to