zjncs opened a new pull request, #7254:
URL: https://github.com/apache/rocketmq-dashboard/pull/7254

   ## Problem
   
   The DLQ CSV export carries a `Retry Count` column 
(`web/src/pages/instance/dlq.tsx:74`), but the only `DLQGroupVO` producer 
hardcodes `.retryCount(0)` for every group (`RocketMQDLQProvider.java:186`; 
grep confirms no other producer). Every row of every exported CSV claims `Retry 
Count 0` regardless of the group's actual retry activity — misleading data an 
operator may use to triage dead-letter severity. A true count needs per-message 
`reconsumeTimes`, which the provider does not fetch.
   
   ## Fix
   
   Remove the always-zero column from the export column list. Nothing else on 
the page consumes `retryCount`.
   
   ## Verification
   
   - New regression test in `DLQPage.test.tsx` first: RED — header contained 
`Retry Count`; GREEN after the fix — 40/40 pass (`npx vitest run 
DLQPage.test.tsx`).
   - `eslint` on the touched file: 0 errors (1 pre-existing react-refresh 
warning). `tsc -b --noEmit`: exit 0.
   
   ## Risk / conflict disclosure
   
   Behavior change is deliberately narrow: the CSV loses a column that was 
constant zero. Several open PRs touch `dlq.tsx` (none touch the export 
columns); happy to rebase if needed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to