prateekm commented on code in PR #1650:
URL: https://github.com/apache/samza/pull/1650#discussion_r1086025969
##########
samza-core/src/main/java/org/apache/samza/config/BlobStoreConfig.java:
##########
@@ -23,19 +23,56 @@
* Config related helper methods for BlobStore.
*/
public class BlobStoreConfig extends MapConfig {
+
+ private static final String PREFIX = "blob.store.";
+ public static final String BLOB_STORE_MANAGER_FACTORY = PREFIX +
"manager.factory";
+ public static final String DEFAULT_BLOB_STORE_MANAGER_FACTORY =
"com.linkedin.samza.ambry.AmbryBlobStoreManagerFactory";
+ public static final String BLOB_STORE_ADMIN_FACTORY = PREFIX +
"admin.factory";
+ public static final String DEFAULT_BLOB_STORE_ADMIN_FACTORY =
"com.linkedin.samza.ambry.AmbryBlobStoreAdminFactory";
+ // Configs related to retry policy of blob stores
+ public static final String BLOB_STORE_RETRY_POLICY_MAX_RETRIES = PREFIX +
"retry.policy.max.retries";
+ // -1 for RetryPolicy means unlimited retries. Retry is limited by max retry
duration, rather than count of retries.
+ public static final int DEFAULT_BLOB_STORE_RETRY_POLICY_MAX_RETRIES = -1;
+ public static final String
BLOB_STORE_RETRY_POLICY_MAX_RETRIES_DURATION_MILLIS = PREFIX +
"retry.policy.max.retires.duration.millis";
Review Comment:
Declare a new variable RETRY_POLICY_PREFIX = PREFIX + "retry.policy."
instead of duplicating boilerplate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
