prateekm commented on code in PR #1650:
URL: https://github.com/apache/samza/pull/1650#discussion_r1092590749
##########
samza-core/src/main/java/org/apache/samza/config/BlobStoreConfig.java:
##########
@@ -24,18 +24,59 @@
*/
public class BlobStoreConfig extends MapConfig {
- public static final String BLOB_STORE_MANAGER_FACTORY =
"blob.store.manager.factory";
- public static final String BLOB_STORE_ADMIN_FACTORY =
"blob.store.admin.factory";
+ private static final String PREFIX = "blob.store.";
+ public static final String BLOB_STORE_MANAGER_FACTORY = PREFIX +
"manager.factory";
+ public static final String BLOB_STORE_ADMIN_FACTORY = PREFIX +
"admin.factory";
+ // Configs related to retry policy of blob stores
+ private static final String RETRY_POLICY_PREFIX = PREFIX + "retry.policy.";
+ public static final String RETRY_POLICY_MAX_RETRIES = RETRY_POLICY_PREFIX +
"max.retries";
+ // -1 for RetryPolicy means unlimited retries. Retry is limited by max retry
duration, rather than count of retries.
+ public static final int DEFAULT_RETRY_POLICY_MAX_RETRIES = -1;
+ public static final String RETRY_POLICY_MAX_RETRY_DURATION_MILLIS =
RETRY_POLICY_PREFIX + "max.retry.duration.millis";
+ public static final long DEFAULT_RETRY_POLICY_MAX_RETRY_DURATION_MILLIS = 10
* 60 * 1000; // 10 mins
+ public static final String RETRY_POLICY_BACKOFF_DELAY_MILLIS =
RETRY_POLICY_PREFIX + "backoff.delay.millis";
+ public static final long DEFAULT_RETRY_POLICY_BACKOFF_DELAY_MILLIS = 100;
+ public static final String RETRY_POLICY_BACKOFF_MAX_DELAY_MILLIS =
RETRY_POLICY_PREFIX + "backoff.max.delay.millis";
+ public static final long DEFAULT_RETRY_POLICY_BACKOFF_MAX_DELAY_MILLIS =
312500;
+ public static final String RETRY_POLICY_BACKOFF_DELAY_FACTOR =
RETRY_POLICY_PREFIX + "backoff.delay.factor";
+ public static final int DEFAULT_RETRY_POLICY_BACKOFF_DELAY_FACTOR = 5;
+ public static final String RETRY_POLICY_JITTER_FACTOR_MILLIS =
RETRY_POLICY_PREFIX + "jitter.factor.millis";
+ // random retry delay between -100 to 100 millisecond
+ public static final long DEFAULT_RETRY_POLICY_JITTER_FACTOR_MILLIS = 100;
Review Comment:
This is factor, not amount, right? Is this defaulting to a factor of 100?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
