shekhars-li commented on code in PR #1650:
URL: https://github.com/apache/samza/pull/1650#discussion_r1092596582
##########
samza-core/src/main/java/org/apache/samza/util/FutureUtil.java:
##########
@@ -143,20 +143,32 @@ public static <K, V> CompletableFuture<Map<K, V>>
toFutureOfMap(
}
public static <T> CompletableFuture<T> executeAsyncWithRetries(String opName,
- Supplier<? extends CompletionStage<T>> action,
- Predicate<? extends Throwable> abortRetries,
+ Supplier<? extends CompletionStage<T>> action, Predicate<? extends
Throwable> abortRetries,
Review Comment:
Not used anymore. Left it, in case someone wanted to use the default retry
policy. Removing it for now
##########
samza-core/src/main/java/org/apache/samza/storage/blobstore/util/BlobStoreUtil.java:
##########
@@ -82,17 +86,21 @@ public class BlobStoreUtil {
private final BlobStoreManager blobStoreManager;
private final ExecutorService executor;
+ private final BlobStoreConfig blobStoreConfig;
private final BlobStoreBackupManagerMetrics backupMetrics;
private final BlobStoreRestoreManagerMetrics restoreMetrics;
private final SnapshotIndexSerde snapshotIndexSerde;
+ private final RetryPolicy<Object> retryPolicy;
- public BlobStoreUtil(BlobStoreManager blobStoreManager, ExecutorService
executor,
+ public BlobStoreUtil(BlobStoreManager blobStoreManager, ExecutorService
executor, BlobStoreConfig blobStoreConfig,
BlobStoreBackupManagerMetrics backupMetrics,
BlobStoreRestoreManagerMetrics restoreMetrics) {
this.blobStoreManager = blobStoreManager;
this.executor = executor;
+ this.blobStoreConfig = blobStoreConfig;
this.backupMetrics = backupMetrics;
this.restoreMetrics = restoreMetrics;
this.snapshotIndexSerde = new SnapshotIndexSerde();
+ this.retryPolicy = buildRetryPolicyFromConfig();
Review Comment:
Thank you! Updating it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
