davidzollo commented on code in PR #10925:
URL: https://github.com/apache/seatunnel/pull/10925#discussion_r3689161420
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-file-ftp-e2e/src/test/java/org/apache/seatunnel/e2e/connector/file/ftp/FtpFileIT.java:
##########
@@ -765,6 +884,38 @@ private void ensureReadJsonInputFile() throws IOException,
InterruptedException
Assertions.assertEquals(0, chmodResult.getExitCode(),
chmodResult.getStderr());
}
+ /**
+ * The multiple-table FTP JSON test reads two logical tables from two
table configs. Give each
+ * table its own physical source file so one reader never depends on a
file already consumed by
+ * the other table path.
+ */
+ private void ensureMultipleTableJsonInputFiles() throws IOException,
InterruptedException {
Review Comment:
Addressed in the current head. `ensureMultipleTableJsonInputFiles` now has
Javadoc stating that this helper owns `tmp/seatunnel/read/json` for the suite
lifetime and rebuilds it before the multiple-table run, so future tests have an
explicit ownership boundary before reusing that shared path.
##########
seatunnel-e2e/seatunnel-connector-v2-e2e/connector-rocketmq-e2e/src/test/java/org/apache/seatunnel/e2e/connector/rocketmq/RocketMqIT.java:
##########
@@ -806,6 +837,15 @@ private long getTopicMaxOffset(String topicName) {
}
}
+ /**
+ * Returns a collision-resistant suffix for broker resources shared by
template invocations.
+ *
+ * @return UUID text without separators, suitable for topic and
consumer-group names
+ */
+ private String uniqueTestSuffix() {
Review Comment:
Addressed in the current head. `uniqueTestSuffix` now documents the
UUID-backed collision boundary and notes that RocketMQ accepts independent
topic creation requests, so the per-invocation topic and consumer-group names
do not require synchronization.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
