DanielLeens commented on issue #11007:
URL: https://github.com/apache/seatunnel/issues/11007#issuecomment-5148482005

   Thanks, `connector-assert` is a good slice to claim.
   
   Please keep the boundary exactly as discussed: rely on 
`OptionRule.required(RULES)` for the top-level missing `rules` case, keep the 
parsed/effectively-empty rule protection inside `AssertSink`, and add focused 
tests for both missing rules and present-but-empty rules.
   
   Do not change the runtime assertion semantics in the same PR. Once your PR 
is open, please link it here so the tracker can show `connector-assert` as in 
review instead of open for another contributor.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to