nzw921rx commented on code in PR #11215:
URL: https://github.com/apache/seatunnel/pull/11215#discussion_r3756323947
##########
seatunnel-engine/seatunnel-engine-server/src/main/java/org/apache/seatunnel/engine/server/telemetry/metrics/exports/ClusterMetricExports.java:
##########
@@ -43,6 +47,14 @@ public List<MetricFamilySamples> collect() {
clusterTime(mfs);
Review Comment:
Thank you for your contribution. I have a non blocking small question here.
If the cluster is not fully formed, should we not expose any indicators?
examples:
```java
if (!isMaster()) {
return mfs;
}
nodeCount(mfs);
// operator-facing cluster health
clusterHealth(mfs);
// topology change counters and timestamps
clusterTopology(mfs);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
