DanielLeens commented on PR #11215: URL: https://github.com/apache/seatunnel/pull/11215#issuecomment-5287968161
Thanks @nzw921rx for the question and @dybyte for confirming. Just to close the loop on this thread for anyone following along: the `nodeCount()` vs `isMaster()`-gated `clusterHealth()`/`clusterTopology()` split at `ClusterMetricExports.java:41-58` is deliberate, not an oversight - `node_count` is exported unconditionally from every member because a member's own view of cluster size is itself a useful observability signal (a node that can't see the full membership, e.g. during a split-brain or before master election completes, will report a divergent `node_count`), whereas `clusterHealth`/`clusterTopology` are the master-authoritative narrative signals and are gated to the active master specifically to avoid duplicate/conflicting series. That matches @dybyte's summary, and I don't read this exchange as raising a new source-level concern. Re-checking the rest of the PR on the unchanged head `e14f48bf`: - No new commits since my last full pass. - `mergeStateStatus` is still `DIRTY` and `mergeable` is still `CONFLICTING` against `dev`. - The branch has drifted further since I last flagged this on 2026-07-19: `ahead_by=3`, `behind_by=303` now, versus `behind_by=145` at that time. - Nothing in this round of discussion changes the source-level conclusion. So the prior conclusion stands as-is: the source-side review is clear and `Build` was green on this head, but GitHub still reports merge conflicts with `dev`. Please sync the latest `dev` and resolve the conflicts. After the updated head is pushed and checks rerun, a write-capable maintainer can complete the final approval gate. @dybyte, whenever you get a chance, that sync-and-resolve step is the one remaining item to unblock this from Daniel's side - happy to take another pass as soon as the updated head is pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
