DanielLeens commented on PR #11390: URL: https://github.com/apache/seatunnel/pull/11390#issuecomment-5301465208
Two updates since my last review of this head (`500d93b2`), neither requiring a source-level re-review: 1. **New blocker: merge conflicts.** GitHub is now reporting this branch as `CONFLICTING`/`DIRTY` against the latest `dev` (it was clean at my last review). Please sync with the latest `dev` and resolve the conflicts first. 2. **CI status.** The `Build` check on this head is currently failing in `TestPythonTransformIT` — but on the `Spark:3.3.0` container variant (`execInContainer can only be used while the Container is running` in `installPythonAndConfigurePolicy`), not on the `Flink:1.20.1` variant this PR's fix specifically targets. That looks like a Testcontainers lifecycle-timing issue unrelated to this PR's `JAVA_TOOL_OPTIONS`-only change for the Flink container, but since the conflict needs resolving anyway, please rerun CI on the synced head and I'll take another look at the fresh result — if the Spark-variant failure persists after the sync, it's worth a closer look, but I wouldn't expect a fix scoped to Flink container property injection to affect the Spark path. No change to my source-level conclusion: production source is unchanged since 2026-07-29 and this commit is a minimal, well-reasoned, test-only fix for the Flink 1.20 issue it targets. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
