nzw921rx commented on code in PR #11827:
URL: https://github.com/apache/seatunnel/pull/11827#discussion_r3794837524
##########
seatunnel-connectors-v2/connector-prometheus/src/main/java/org/apache/seatunnel/connectors/seatunnel/prometheus/sink/PrometheusWriter.java:
##########
@@ -113,6 +114,18 @@ public void write(Point record) {
}
}
+ @Override
+ public Optional<Void> prepareCommit() {
Review Comment:
Thanks for your contribution. My understanding is that the semantics of
`prepareCommit()` here are specifically intended to support 2PC, working
together with the engine's checkpoint mechanism to provide exactly-once
semantics. With that in mind, I think handling `flush()` here would be
inconsistent with the intended API semantics, so I would prefer that we not
support `flush()` in `prepareCommit()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
