surafel58 commented on PR #11827: URL: https://github.com/apache/seatunnel/pull/11827#issuecomment-5317696651
Thanks @nzw921rx for the careful look at the prepareCommit semantics, and @DanielLeens for the precedent analysis. Agreed on the resolution: Prometheus remote-write has no transactional path, and flush() + Optional.empty() in prepareCommit() follows the same non-2PC shape already used by Doris, Elasticsearch, ClickHouse, StarRocks, and MongoDB (Doris does it conditionally in the same method). On Issue 1, I will make the idempotency assumption explicit in the prepareCommit() comment: a failed checkpoint flush replays from the last successful checkpoint on restart, which is safe because Prometheus remote-write is an idempotent upsert keyed by (labels, timestamp). I will also name the sibling-connector precedent in the comment. Pushing shortly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
